Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gogetdoc gets stuck when operating on files with errors #56

Open
ramya-rao-a opened this issue Feb 24, 2019 · 1 comment
Open

gogetdoc gets stuck when operating on files with errors #56

ramya-rao-a opened this issue Feb 24, 2019 · 1 comment

Comments

@ramya-rao-a
Copy link

VS Code Issue reference: microsoft/vscode-go#2084

Turns out gogetdoc gets stuck when operating on files with errors.

Sample code:

package main

import (
	"fmt"
	"io/ioutil"
	"os"
)

func main() {
	fmt.Pri ntln("hallo")
	ioutil.ReadAll(os.Stdin)
}

Run gogetdoc on the ReadAll symbol with the above code. gogetdoc will be stuck and not return results

Try again after fixing the Println. Everything would be fine now.

@zmb3
Copy link
Owner

zmb3 commented Mar 2, 2019

b37376c fixes the deadlock, so it won't get stuck on this case anymore but it will fail to return documentation. Looking to see if there's anything we can do or if the AST simply isn't in good enough shape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants