refactor: use replace syntax to import zdns/dns #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Workaround: zmap/dns#14 |
...to fix the go mod tidy issue
developStorm
commented
Oct 31, 2024
| github.com/zmap/go-iptree v0.0.0-20210731043055-d4e632617837 | ||
| github.com/zmap/zcrypto v0.0.0-20240803002437-3a861682ac77 | ||
| github.com/zmap/zflags v1.4.0-beta.1.0.20200204220219-9d95409821b6 | ||
| github.com/zmap/zgrab2 v0.1.8 | ||
| gotest.tools/v3 v3.5.1 | ||
| ) | ||
|
|
||
| replace github.com/miekg/dns => github.com/zmap/dns v1.1.63-zdns1 |
There was a problem hiding this comment.
zmap/dns v1.1.63* is miekg/dns v1.1.62. New tags are just to bypass go proxy cache system.
zakird
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables data type compatibility for interoperability with libraries that reference
miekgtypes. Currently, it allows us to import go-dns-root-anchors, but it also provides future extensibility. If we introduce other dependencies that rely onmiekg/dns, this adjustment will enable us to transparently replacemiekg/dnswith our version.Additionally, it ensures that
zmap/dnsinterfaces and data types remain aligned withmiekg/dns, guarding for inadvertent compatibility issues.Alternatives considered:
zmap/dnsforgo-dns-root-anchors: While this approach works, it would limit the utility of the root anchors library to primarily our use case. Additionally, if we need to add another dependency that relies onmiekg/dnsand isn’t under our control, we’d encounter the same compatibility issue.