Refactor: Allow More Answer Types to Be Cacheable #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developStorm
changed the title
|
And for context, this is going to enable us to cache |
developStorm
force-pushed
the
refactor/generic-cache
branch
3 times, most recently
from
d4b6483
to
63f8763
Compare
dadrian
approved these changes
Nov 1, 2024
developStorm
force-pushed
the
refactor/generic-cache
branch
from
63f8763
to
414dc59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
WithBaseAnswerinterface as the cache value type to allow broader answer types to be included in the cache. Theanswers_generate.goscript, when run withgo generate, implements the required interface functionBaseAnsfor each eligible answer struct.