Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs cause circuit compilation to fail #5

Open
Divide-By-0 opened this issue Sep 26, 2024 · 1 comment · Fixed by #16
Open

Bugs cause circuit compilation to fail #5

Divide-By-0 opened this issue Sep 26, 2024 · 1 comment · Fixed by #16
Labels
bug Something isn't working high

Comments

@Divide-By-0
Copy link
Member

Divide-By-0 commented Sep 26, 2024

  • Error: Connector not connected. when clicking 'verify' after sending on chain for the luma proof
  • we should warn when we see a space after a colon in the regex definition
  • when the regex fails, we should show a tooltip in the frontend on top of the X saying that i.e. regex doesnt match, or the dkim key doesnt exist (note that its maybe too or too new if we have a key for that selector but the date range doesnt overlap)
  • when regex doesnt match, the idx is not generated, but it should just show an X saying that the regex doesn't match and disallow proof gen

Fixed in #14

  • You cannot have just one private input, or else there will be a compile error where it tries to capture the nonexistent reveal block from the regex. Blocked in frontend for now, but ideally should be fixed in the circuit generation
  • names of fields should replace spaces with underscores

Fixed in #10

  • when asking for a domain in the config, disallow people to put whole emails
  • Names of fields cannot have spaces
@Divide-By-0 Divide-By-0 changed the title Bugs Bugs cause circuit compilation to fail Sep 26, 2024
@Divide-By-0 Divide-By-0 added bug Something isn't working high labels Sep 26, 2024
@javiersuweijie
Copy link
Collaborator

javiersuweijie commented Oct 2, 2024

when regex doesnt match, the idx is not generated, but it should just show an X saying that the regex doesn't match and disallow proof gen

Fixed in: #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants