Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate API v2beta -> v2 #373

Open
1 task
Tracked by #8516
muhlemmer opened this issue Sep 3, 2024 · 0 comments
Open
1 task
Tracked by #8516

Migrate API v2beta -> v2 #373

muhlemmer opened this issue Sep 3, 2024 · 0 comments

Comments

@muhlemmer
Copy link
Contributor

As we release v2 GA we should migrate this SDK from v2beta to v2.

Acceptance criteria

  • v2 API protos are used
@muhlemmer muhlemmer moved this to 🧐 Investigating in Product Management Sep 3, 2024
@stebenz stebenz added the v3 label Sep 17, 2024
@stebenz stebenz moved this from 🧐 Investigating to 📋 Sprint Backlog in Product Management Sep 17, 2024
livio-a added a commit that referenced this issue Sep 24, 2024
This PR generates the missing V2 of the user client as mentioned in
#373

v2beta is deprecated and is throwing warnings when using the client.
This adds the GA v2 client without breaking the applications that are
already on v2beta

Biggest change other than adding the generated code is to add a methods
to `pkg/client/client.go` to support the new client versions

### Definition of Ready

- [x] I am happy with the code
- [x] Short description of the feature/issue is added in the pr
description
- [x] PR is linked to the corresponding user story
- [x] Acceptance criteria are met
- [x] All open todos and follow ups are defined in a new ticket and
justified
- [x] Deviations from the acceptance criteria and design are agreed with
the PO and documented.
- [x] No debug or dead code
- [x] My code has no repetitions
- [ ] Critical parts are tested automatically
- [x] Where possible E2E tests are implemented
- [x] Documentation/examples are up-to-date
- [x] All non-functional requirements are met
- [x] Functionality of the acceptance criteria is checked manually on
the dev system.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Sprint Backlog
Development

No branches or pull requests

2 participants