Skip to content

Commit

Permalink
Ignore unexpected properties (#1476)
Browse files Browse the repository at this point in the history
  • Loading branch information
DerManoMann authored Sep 7, 2023
1 parent e1062da commit 6124237
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions src/Annotations/AbstractAnnotation.php
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,7 @@ public function __set(string $property, $value): void
foreach (static::$_blacklist as $_property) {
unset($fields[$_property]);
}
$this->_context->logger->warning('Unexpected field "' . $property . '" for ' . $this->identity() . ', expecting "' . implode('", "', array_keys($fields)) . '" in ' . $this->_context);
$this->{$property} = $value;
$this->_context->logger->warning('Ignoring unexpected property "' . $property . '" for ' . $this->identity() . ', expecting "' . implode('", "', array_keys($fields)) . '" in ' . $this->_context);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/Annotations/AbstractAnnotationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public function testVendorFields(): void
*/
public function testInvalidField(): void
{
$this->assertOpenApiLogEntryContains('Unexpected field "doesnot" for @OA\Get(), expecting');
$this->assertOpenApiLogEntryContains('Ignoring unexpected property "doesnot" for @OA\Get(), expecting');
$this->annotationsFromDocBlockParser('@OA\Get(doesnot="exist")');
}

Expand Down

0 comments on commit 6124237

Please sign in to comment.