Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer home directory is not properly set for some users/systems #12

Open
acoulton opened this issue Nov 18, 2014 · 0 comments
Open

Comments

@acoulton
Copy link
Contributor

The composer_project resource defines a COMPOSER_HOME environment variable in the home directory of the composer user. However this is hardcoded:

environment({"COMPOSER_HOME" => "/home/#{new_resource.run_as}/.composer"})

This means that if the user has a nonstandard home directory (eg because it's a system user like www-data) it will fail to pick up the config files etc.

I think the proper way to do this would be to take the home directory from node['etc']['passwd'][new_resource.run_as]['dir'] - but probably it's best to calculate this as a default so that the end-user can also customise the home directory if required.

I can submit a pull if this seems like the right fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant