Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FunctionDefSpec #732

Open
jczuchnowski opened this issue Jul 22, 2022 · 0 comments
Open

Improve FunctionDefSpec #732

jczuchnowski opened this issue Jul 22, 2022 · 0 comments

Comments

@jczuchnowski
Copy link
Member

We need to make the tests between different modules more unified and consistent.

Starting with FunctionDefSpec (for every db-module):

  • split the FunctionDefSpec into CommonFunctionDefSpec and CustomFunctionDefSpec
  • CommonFunctionDefSpec should containt tests for all common functions defined in the Expr module https://github.com/zio/zio-sql/blob/master/core/jvm/src/main/scala/zio/sql/expr.scala#L389
  • CustomFunctionsDefSpec should contain tests for the db-specific functions defined in each db-specific *SqlModule
  • code duplication between the dbs is fine for CommonFunctionDefSpec unless there's another way to deal with it (base test class?)
bogatyra pushed a commit to bogatyra/zio-sql that referenced this issue Jul 29, 2022
bogatyra pushed a commit to bogatyra/zio-sql that referenced this issue Jul 29, 2022
bogatyra pushed a commit to bogatyra/zio-sql that referenced this issue Jul 29, 2022
bogatyra pushed a commit to bogatyra/zio-sql that referenced this issue Jul 29, 2022
bogatyra pushed a commit to bogatyra/zio-sql that referenced this issue Jul 29, 2022
bogatyra added a commit to bogatyra/zio-sql that referenced this issue Jul 31, 2022
bogatyra pushed a commit to bogatyra/zio-sql that referenced this issue Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant