Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HikariCP implementation of the ConnectionPool #639

Open
jczuchnowski opened this issue Apr 28, 2022 · 1 comment
Open

Add HikariCP implementation of the ConnectionPool #639

jczuchnowski opened this issue Apr 28, 2022 · 1 comment
Labels
ziohackathon

Comments

@jczuchnowski
Copy link
Member

jczuchnowski commented Apr 28, 2022 •
edited
Loading

We want users to have an option of HikariCP connection pool in addition to ZIO SQL native one.

This should be a wrapper over HikariDataSource that would implement zio.sql.ConnectionPool interface.

Should be implemented in a separate sbt module (eg. jdbc-hickaricp), so that it can be optionally imported and not "pollute" the dependencies of the main module.
@jczuchnowski jczuchnowski added enhancement New feature or request and removed enhancement New feature or request labels Apr 28, 2022
@sergeda
Copy link
Contributor

sergeda commented May 27, 2022

I'd like to work on this

sergeda added a commit to sergeda/zio-sql that referenced this issue May 30, 2022
@sergeda
Adds HikariCP (zio#639)
a3d1e27
sergeda added a commit to sergeda/zio-sql that referenced this issue May 31, 2022
@sergeda
Adds option for connectionInitSql (zio#639)
9658c65
sviezypan added a commit that referenced this issue Aug 27, 2022
@sviezypan
Merge pull request #704 from sergeda/639_hikaricp
781242c 
Adds HikariCP (#639)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ziohackathon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdegoes @sergeda @jczuchnowski