Don't discard the timezone information when reading timezone with tim… #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which DB are you using? |
|
I tested this using duckdb
…On Sat, 6 Apr 2024 at 07:11, Jules Ivanic ***@***.***> wrote:
Which DB are you using?
—
Reply to this email directly, view it on GitHub
<#196 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAO73SVWOSS2YG7YNP2E4HDY357ZDAVCNFSM6AAAAABFZIRB3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQHE3DSNRRGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Is there anything else you need to get more confidence on this change? |
|
@olivierdeckers Can you please add some tests? |
olivierdeckers
commented
Apr 16, 2024
| } yield zConnection | ||
| ) | ||
|
|
||
| case class OffsetDateTimeRow(value: OffsetDateTime) |
There was a problem hiding this comment.
When using query[OffsetDateTime] directly things were working already, the code path I changed in JdbcDecoder is only hit when using the JdbcDecoder.fromSchema
There was a problem hiding this comment.
Without the change, the case class would have had to have an Instant field instead of an OffsetDateTime field.
The data would be returned in the default system timezone, but interpreted as a timestamp in UTC. Where I live this results in a 2 hour offset currently between writing and reading an OffsetDateTimeRow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…estamp from the database