Metric for number of open connections #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's do |
jdegoes
reviewed
May 27, 2022
| @@ -26,6 +26,8 @@ import java.sql.Connection | |||
| */ | |||
| final case class ZConnectionPool(transaction: ZLayer[Any, Throwable, ZConnection]) | |||
| object ZConnectionPool { | |||
| private[jdbc] val connectionsCounter = zio.metrics.Metric.counterInt("zio_jdbc_open_connections") | |||
There was a problem hiding this comment.
You need a Gauge here because some metric systems do not allow incrementing by negative numbers.
Otherwise, looks good to merge!
|
@nhyne Please re-open when you are ready for this to be merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an
open_connectionsmetric to track the number of connections currently open in the pool.Is this name for the metric okay or should it be camel case and/or named something different?
I think this closes #6 but if I missed something let me know.