Advanced ReOrg Test: ReOrg changes tx height #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacu
force-pushed
the
arot-tx-height-changes
branch
2 times, most recently
from
e1a0a61 to
77af137
Compare
zancas
reviewed
Oct 19, 2023
zancas
reviewed
Oct 19, 2023
There was a problem hiding this comment.
Looks pretty good so far! I'd like @Oscar-Pepper to review it before landing.
pacu
added a commit
to pacu/zingolib
that referenced
this pull request
Oct 19, 2023
…saction Closes zingolabs#609 builds on top of zingolabs#593
This was referenced Oct 19, 2023
pacu
force-pushed
the
arot-tx-height-changes
branch
3 times, most recently
from
62974cd to
dd0dece
Compare
pacu
added a commit
to pacu/zingolib
that referenced
this pull request
Nov 10, 2023
…saction Closes zingolabs#609 builds on top of zingolabs#593 Fix Clippy
pacu
force-pushed
the
arot-tx-height-changes
branch
from
dd0dece to
41504cf
Compare
pacu
added a commit
to pacu/zingolib
that referenced
this pull request
Nov 13, 2023
…saction Closes zingolabs#609 builds on top of zingolabs#593 Fix Clippy
pacu
force-pushed
the
arot-tx-height-changes
branch
from
41504cf to
21d9f07
Compare
Verifies that the wallet reacts properly to a reorg that changes the block_height of a transaction that was confirmed in a block prior and moved to a newer block and confirmed again. This also disables TreeState verification for feature `darkside_tests` Add features to disable TreeState verification on `darkside_tests` Fix Whitespace Clippy issue Fix integration_tests.rs compile errors
pacu
force-pushed
the
arot-tx-height-changes
branch
from
7cc291b to
023a313
Compare
pacu
added a commit
to pacu/zingolib
that referenced
this pull request
Nov 22, 2023
…saction Closes zingolabs#609 builds on top of zingolabs#593 Fix Clippy
pacu
added a commit
to pacu/zingolib
that referenced
this pull request
Nov 23, 2023
…saction Closes zingolabs#609 builds on top of zingolabs#593 Fix Clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes pacu/zcash-dev-rel-engineer#42
This implements an advanced Re Org test that uses this dataset zingolabs/darksidewalletd-datasets#13