Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade librustzcash #590

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Upgrade librustzcash #590

merged 2 commits into from
Oct 13, 2023

Conversation

zancas
Copy link
Member

@zancas zancas commented Oct 13, 2023

Several changes have landed in librustzcash main that we use:

  • MARGINAL_FEE
  • TransactionBuilder::get_fee

This PR upgrades our fork/zingo_rc.2 snapshot of librustzcash so we pick up those changes.

To work around the deprecation of impl From<u64> for Amount which effects values we depend on, like TxOut::value we use try_from. I think those values are likely to be ported to NonNegativeAmounts soon. That's work that we're well suited to and interested in, if that's the case.

@zancas zancas requested a review from Oscar-Pepper October 13, 2023 05:16
@Oscar-Pepper Oscar-Pepper merged commit d359c39 into zingolabs:dev Oct 13, 2023
16 checks passed
@zancas zancas deleted the upgrade_librustzcash branch May 30, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oscar-Pepper Oscar-Pepper Oscar-Pepper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zancas @Oscar-Pepper