Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove getset from zingo-sync #1573

Closed
wants to merge 15 commits into from
Closed

remove getset from zingo-sync #1573

wants to merge 15 commits into from

Commits on Dec 2, 2024

  1. remove getset from ScanningKeys 

    complete removal, of getset, discover uncalled spend_locations
    @zancas
    zancas committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    8f3f65c View commit details
    Browse the repository at this point in the history

  2. NOTE: We'll revisit all allow\(dead_code\) soon

    @zancas
    zancas committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    1045a3b View commit details
    Browse the repository at this point in the history

  3. remove getset from nullifier_map

    @zancas
    zancas committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    3a27921 View commit details
    Browse the repository at this point in the history

  4. remove getset from witness

    @zancas
    zancas committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    257f8c8 View commit details
    Browse the repository at this point in the history

  5. wip

    @zancas
    zancas committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    50c8597 View commit details
    Browse the repository at this point in the history

  6. wip

    @zancas
    zancas committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    c1574cc View commit details
    Browse the repository at this point in the history

  7. more pub(crate)

    @zancas
    zancas committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    e15223d View commit details
    Browse the repository at this point in the history

  8. complete excision of getset, reveals dead code

    @zancas
    zancas committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    167404b View commit details
    Browse the repository at this point in the history

  9. the dead_code blocks will be analyzed shortly

    @zancas
    zancas committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    7432219 View commit details
    Browse the repository at this point in the history

  10. comment out usage in test

    @zancas
    zancas committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    35eb576 View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'zingolabs/dev' into remove_getset_from_… 

    …sync
    @zancas
    zancas committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    b57055a View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2024

  1. grab upstream zingo-sync/src/sync.rs and remove getters

    @zancas
    zancas committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    87b011e View commit details
    Browse the repository at this point in the history

  2. add dev, but remove getset

    @zancas
    zancas committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    b81f594 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'zingolabs/dev' into remove_getset_from_… 

    …sync
    @zancas
    zancas committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    e5a88b9 View commit details
    Browse the repository at this point in the history

  4. finish getset elision

    @zancas
    zancas committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    ea6c317 View commit details
    Browse the repository at this point in the history