Merge pull request #1358 from fluidvanadium/remove_todos

some cleanup, removing todos
zingolabs · Sep 7, 2024 · efc2fd5 · efc2fd5
2 parents 4f03483 + 6d71694
commit efc2fd5
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 25 deletions.
diff --git a/zingolib/src/lightclient.rs b/zingolib/src/lightclient.rs
@@ -514,7 +514,7 @@ impl LightClient {
         }
     }
 
-    /// TODO!! This function sorts notes into
+    /// This function sorts notes into
     /// unspent
     /// spend_is_pending
     /// spend_is_confirmed

diff --git a/zingolib/src/testutils/grpc_proxy.rs b/zingolib/src/testutils/grpc_proxy.rs
@@ -186,7 +186,7 @@ impl CompactTxStreamer for ProxyServer {
         'life0: 'async_trait,
         Self: 'async_trait,
     {
-        todo!("this isn't expected to be called. Please implement this if you need it")
+        unimplemented!("this isn't expected to be called. Please implement this if you need it")
     }
 
     #[doc = "Server streaming response type for the GetMempoolTx method."]

diff --git a/zingolib/src/wallet/disk/testing/examples.rs b/zingolib/src/wallet/disk/testing/examples.rs
@@ -157,26 +157,3 @@ impl LightWallet {
         }
     }
 }
-
-// /// loads test wallets
-// impl LightWallet {
-//     /// each wallet file has a saved balance
-//     pub fn example_expected_balance(case: LegacyWalletCase) -> u64 {
-//         match case {
-//             // LegacyWalletCase::ZingoV26(LegacyWalletCaseZingoV26::One) => 0,
-//             // LegacyWalletCase::ZingoV26(LegacyWalletCaseZingoV26::Two) => 10177826,
-//             LegacyWalletCase::ZingoV26(LegacyWalletCaseZingoV26::RegtestSapOnly) => todo!(),
-//             LegacyWalletCase::ZingoV28 => 10342837,
-//         }
-//     }
-
-//     /// each wallet file has a saved balance
-//     pub fn example_expected_num_addresses(case: LegacyWalletCase) -> usize {
-//         match case {
-//             // LegacyWalletCase::ZingoV26(LegacyWalletCaseZingoV26::One) => 3,
-//             // LegacyWalletCase::ZingoV26(LegacyWalletCaseZingoV26::Two) => 1,
-//             LegacyWalletCase::ZingoV26(LegacyWalletCaseZingoV26::RegtestSapOnly) => todo!(),
-//             LegacyWalletCase::ZingoV28 => 3,
-//         }
-//     }
-// }