Merge pull request #648 from AloeareV/only_add_to_empty_metadata

Only add outgoing metadata when empty to begin with
zingolabs · Nov 1, 2023 · d6efd1e · d6efd1e
2 parents 8cd3b3b + 0d62116
commit d6efd1e
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/zingolib/src/wallet/transactions.rs b/zingolib/src/wallet/transactions.rs
@@ -862,16 +862,10 @@ impl TransactionMetadataSet {
     pub fn add_outgoing_metadata(&mut self, txid: &TxId, outgoing_metadata: Vec<OutgoingTxData>) {
         // println!("        adding outgoing metadata to txid {}", txid);
         if let Some(transaction_metadata) = self.current.get_mut(txid) {
-            for outgoing_metadatum in outgoing_metadata {
-                if !transaction_metadata
+            if transaction_metadata.outgoing_tx_data.is_empty() {
+                transaction_metadata
                     .outgoing_tx_data
-                    .iter()
-                    .any(|known_metadatum| *known_metadatum == outgoing_metadatum)
-                {
-                    transaction_metadata
-                        .outgoing_tx_data
-                        .push(outgoing_metadatum);
-                }
+                    .extend(outgoing_metadata);
             }
         } else {
             error!(