Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-mp3 codecs #2

Open
wsc1 opened this issue Aug 6, 2018 · 4 comments
Open

go-mp3 codecs #2

wsc1 opened this issue Aug 6, 2018 · 4 comments

Comments

@wsc1
Copy link
Member

wsc1 commented Aug 6, 2018

Incorporate go-mp3.

@wsc1
Copy link
Member Author

wsc1 commented Aug 15, 2018

based on a small C mp3 library. So we can't incorporate it directly, but perhaps we can make an example people can refer to in case of need while we wait for Go implementations.

@wsc1
Copy link
Member Author

wsc1 commented Sep 9, 2018

Now I'm not sure what made me think it was based on a C mp3 library. README says pure Go, whatever I saw before didn't.

go.mod indicates a dependency on oto.

Licensing is Apache; would be nice to see if it's possible to arrive at a single collective license.

@mewmew
Copy link
Member

mewmew commented Sep 9, 2018

go.mod indicates a dependency on oto.

Would be interesting to see if this dependency can be split out from the rest of the project, to only handle encoding/decoding.

@wsc1
Copy link
Member Author

wsc1 commented Sep 12, 2018

go.mod indicates a dependency on oto.

Would be interesting to see if this dependency can be split out from the rest of the project, to only handle encoding/decoding.

Yes, after this discussion, looks like we're going to try to put it in /ext.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants