Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate groups from coordinator entities to actual devices #149

Open
puddly opened this issue Aug 8, 2024 · 1 comment
Open

Migrate groups from coordinator entities to actual devices #149

puddly opened this issue Aug 8, 2024 · 1 comment
Labels
breaking change PR is a breaking change enhancement New feature or request question Further information is requested

Comments

@puddly
Copy link
Contributor

puddly commented Aug 8, 2024

The issues @dmulcahey brought up in #47 regarding platforms are interesting corner cases that crop up when Zigbee functionality doesn't translate directly to Home Assistant platforms (e.g. a light and a switch both have OnOff clusters and can form a Zigbee group).

One way we can work around this is by turning groups into actual devices: this would allow automations to "turn on" the group device as a whole and the primary entity would be controlled, regardless of its platform. It would also allow the primary entity to switch platforms depending on group composition, which would open up the possibility of heterogeneous groups (1 fan, 1 light, 1 switch) or single-device groups.

Thoughts?

@puddly puddly added enhancement New feature or request question Further information is requested breaking change PR is a breaking change labels Aug 8, 2024
@dmulcahey
Copy link
Contributor

One way we can work around this is by turning groups into actual devices:

I would suggest that if we go down this path that it is contained in the HA side only since that is the only place where this distinction really makes a difference. They are only linked to a device to take advantage of device actions / conditions / triggers.

which would open up the possibility of heterogeneous groups

I like this idea but I also think it could lead to confusion… it holds up well when clusters are the same but toss a fan into the group and now turn on / off semantics get kinda funky. Exposing zigbee scenes may make more sense? Or just avoiding the zigbee scene complexity and advising folks to use the HA scene functionality…

It would also allow the primary entity to switch platforms depending on group composition

This may be considered an undesirable / destructive action by the users? Folks may not be pleased if they are leveraging / targeting the entity in an automation or a script and we change it out from under them because they added another device to the group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change PR is a breaking change enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants