Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parts of askBool-generated questions can be unreadable #9

Open
koachan opened this issue Mar 21, 2022 · 1 comment · May be fixed by #10
Open

Parts of askBool-generated questions can be unreadable #9

koachan opened this issue Mar 21, 2022 · 1 comment · May be fixed by #10

Comments

@koachan
Copy link

koachan commented Mar 21, 2022

I noticed that parts of questions made by zinput can be unreadable when used with dark/light-themed terminal.
Sample program and its output:

const zinput = @import("zinput");

pub fn main() void {
    _ = zinput.askBool("The question is unreadable on light theme, and the y/n prompt is unreadable on dark theme") catch return;
}

How it looks on dark-themed terminal
How it looks on light-themed terminal

@koachan
Copy link
Author

koachan commented Mar 21, 2022

I see that the library uses some hardcoded color values, would it be okay if it's changed into a more neutral combination?
If so then I'll prepare a PR for that.

try out.writeSeq(.{ Fg.Cyan, "? ", Fg.White, prompt, Fg.DarkGray, " (y/n) > " });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant