Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement opcodes 0x71-0x7b #62

Closed
KhairallahA opened this issue Sep 17, 2024 · 9 comments · Fixed by #143
Closed

Implement opcodes 0x71-0x7b #62

KhairallahA opened this issue Sep 17, 2024 · 9 comments · Fixed by #143
Assignees
@KhairallahA

Comments

@KhairallahA
Copy link
Contributor

KhairallahA commented Sep 17, 2024 •
edited
Loading

No description provided.

@tdelabro
Copy link
Collaborator

hey, don't this conflict with #39 ?

If so please close this issue and your PR as it was claimed beforehand

@tdelabro
Copy link
Collaborator

unless @varun-doshi is ok to leave you this one, as he will be working on #65?

@tdelabro
Copy link
Collaborator

As a general rule, @KhairallahA, please refrain from claiming more than 2 issues at the same time

@KhairallahA
Copy link
Contributor Author

hey @tdelabro, but in #39 focus on 0x70-0x72 not same 0x71-0x7b?

@tdelabro
Copy link
Collaborator

they seem to overlap on 0x71 and 0x72

@KhairallahA
Copy link
Contributor Author

As a general rule, @KhairallahA, please refrain from claiming more than 2 issues at the same time

Well, I didn't know that.

@KhairallahA
Copy link
Contributor Author

they seem to overlap on 0x71 and 0x72

I have checked that 0x71 implementation is different from 0x72.
0x71 uses 0x7b method

@varun-doshi
Copy link
Contributor

Hey @KhairallahA you can take up these opcodes.
Let me know if you need any help

@KhairallahA
Copy link
Contributor Author

Hi, @varun-doshi!
Thank you for this, I will

@tdelabro tdelabro mentioned this issue Sep 26, 2024
Closed
@KhairallahA KhairallahA mentioned this issue Sep 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KhairallahA KhairallahA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add OP_ROT OP_2ROT KhairallahA/btczee
3 participants
@tdelabro @varun-doshi @KhairallahA