Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Feature request: Adding Liquid tag support to this package #128

Closed
fusion809 opened this issue Mar 26, 2016 · 5 comments
Closed

Feature request: Adding Liquid tag support to this package #128

fusion809 opened this issue Mar 26, 2016 · 5 comments

Comments

@fusion809
Copy link

Hi,

I frequently use this plugin when writing posts in my Jekyll site (The Hornerysource) and I think it would make things alot easier if this package had support for Liquid tags. So that when one types {% this plugin automatically closes the tag with %}. Also keyboard shortcuts for inserting {% include %}, {% include_relative %}, {% capture %}, {% endcapture %}, {% if %}, {% elsif %}, {% endif %} would be helpful.

Thanks for your time,
Brenton

@fusion809 fusion809 changed the title Feature request: Adding Liquid tag support to package Feature request: Adding Liquid tag support to this package Mar 26, 2016
@zhuochun
Copy link
Owner

Auto closing tags seems to be a potential feature to support.

{% include %} etc probably using snippets are better and easier.

@puranjayjain
Copy link

@zhuochun started work on this one will start a PR soon 👍

@zhuochun
Copy link
Owner

zhuochun commented May 3, 2016

@puranjayjain For this issue, I was thinking on providing the the auto closing tags. It is much like the standard package bracket-matcher with more customization.

I was also hesitated because this feature itself could be just inside the bracket-matcher since the logic would be the same in most of cases. The standard package could allow other packages hook into to register more pairs according to the file types through services.

@puranjayjain
Copy link

So shall we send a PR to bracket matcher itself?

@zhuochun
Copy link
Owner

zhuochun commented May 3, 2016

Look like there is an issue on the similar topic atom/bracket-matcher#182

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants