Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print scene by line #74

Open
Geolle opened this issue Jul 4, 2019 · 3 comments
Open

Print scene by line #74

Geolle opened this issue Jul 4, 2019 · 3 comments

Comments

@Geolle
Copy link

Geolle commented Jul 4, 2019

First, thank you for this cool works.

I have an idea, could it be possible that add a function theater.addLineScene() , and this can be used to print the whole scene line at once.
Because sometimes the typing is kind of too slow even I set the maxSpeed to 1.

Thank you for your consideration!

@zhouzi
Copy link
Owner

zhouzi commented Jul 4, 2019

Thanks for the kind words 😊

Have you tried to play with the minSpeed/maxSpeed options? If TheaterJS had a .addLineScene method, would you always use it or mix it with the current addScene?

@Geolle
Copy link
Author

Geolle commented Jul 5, 2019

I have tried the options maxSpeed, even I set it to zero, the scene is still typing, a little bit slow. I just want the whole line show up at once, like the introduction of the background when the show came up, or the narration of the play.
If TheaterJS had such a method, I would like to use it like this:

theater.addActor('Aside')
           .addActor('Bob')
           .addLineScene('Aside:blablabla')
           .addLineScene('blablabla...')
           .addScene('Bob:blablabla...')
           .addLineScene('blablabla')

I don't know if I express myself clearly, my English is not very well.
Thank you for replying.

@zhouzi
Copy link
Owner

zhouzi commented Jul 5, 2019

Thanks for the details, it's perfectly clear 😉 This is not something TheaterJS can do right now but it could be considered. It raises a few questions though:

  • Is TheaterJS's speed configuration too poor?
  • Should TheaterJS automatically speed up for long text?
  • Are long text well suited for TheaterJS? (e.g isn't the "mistakes" feature annoying in this case?)

TheaterJS is a typing animation library so I'm a bit concerned about adding a feature that goes against that. For example, a good reason to add it would be if it was tied to a particular emotion (which is something TheaterJS is built for).

Anyway, I haven't been working on TheaterJS for some time now so I won't be personally involved in this but I'd be more than happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants