-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
question about subsampler #7
Comments
It's an interesting question. Notice that we have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ngram2vec/ngram2vec/corpus2pairs.py
Line 58 in 6966b1c
I am confused about the sub-sampler in corpus2pairs. I think
1 - sqrt(subsample / count)
should be replaced with1 - sqrt(subsample / (count / total_word_count_in_vocab))
.ps. I might misunderstand your implementation, and in actual implementation of original word2vec.c ,the subsample probability equals
1 - (sqrt(subsample / (count / total_word_count_in_vocab)) + subsample / (count / total_word_count_in_vocab) )
.The text was updated successfully, but these errors were encountered: