feat: Link Datadoc to GitHub Directory #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangvi7
force-pushed
the
github/datadoc-link
branch
from
b4d0a3e to
2ff8786
Compare
jczhong84
reviewed
Oct 25, 2024
| datadoc_id = sql.Column( | ||
| sql.Integer, sql.ForeignKey("data_doc.id"), nullable=False, unique=True | ||
| ) | ||
| user_id = sql.Column(sql.Integer, sql.ForeignKey("user.id"), nullable=False) |
There was a problem hiding this comment.
what is this user_id for ? is it the doc owner or the first user commits the datadoc?
There was a problem hiding this comment.
its the user who links the current GitHubs directory to the datadoc
|
|
||
|
|
||
| @with_session | ||
| def create_repo_link( |
There was a problem hiding this comment.
realized that, do we allow user to unlink a datadoc, or change the directory of the doc?
There was a problem hiding this comment.
Yep, plan to add support for it later on, with maybe a warning saying it will change version history
zhangvi7
force-pushed
the
github/datadoc-link
branch
from
2ff8786 to
daa18d2
Compare
jczhong84
approved these changes
Oct 30, 2024
feat: Add serializing util for datadoc github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes
Depends on PR: pinterest#1497