Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Link Datadoc to GitHub #3

Closed
wants to merge 3 commits into from
Closed

feat: Link Datadoc to GitHub #3

wants to merge 3 commits into from

Conversation

zhangvi7
Copy link
Owner

@zhangvi7 zhangvi7 commented Oct 18, 2024 •
edited
Loading

Context

  • After users complete OAuth flow and have their GitHub token, they can link the datadoc to GitHub
  • Users can choose to specify the repo_url, branch_name, file_path they want to link to on GitHub
    • 1:1 mapping between datadoc and github
  • Users OAuth token needs read permissions for the linked repository to view commits and write permissions for the repository to push/restore a commit

Changes

  • DS: new endpoint to create GH Link
  • DB: Added new data model to store GitHub link
  • Logic: get and create_github_link()

Depends on PR: pinterest#1497

@zhangvi7 zhangvi7 mentioned this pull request Oct 18, 2024
Merged
@zhangvi7 zhangvi7 marked this pull request as ready for review October 18, 2024 17:15
@zhangvi7
Merge pull request #4 from zhangvi7/github/alembic
c6f16e6 
db: GitHub Link table alembic migration
@zhangvi7 zhangvi7 closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhangvi7