Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grub-probe adds trailing slash (if root is on the root dataset). #15

Open
RJVB opened this issue Jun 14, 2014 · 4 comments
Open

grub-probe adds trailing slash (if root is on the root dataset). #15

RJVB opened this issue Jun 14, 2014 · 4 comments

Comments

@RJVB
Copy link

RJVB commented Jun 14, 2014

Reading the upgrade-from-0.6.2 readme that comes with one of the updated packages for Debian (but not on Ubuntu???!) I see that nowadays grub.cfg should have kernel cmdline entries that read something like

{{{
bootfs=rpool/ROOT/debian-1 boot=zfs ro
}}}

(or bootfs=Patux boot=zfs ro in my case).

However, even with the latest grub-pc, grub-pc-bin, grub-common and grub2-common from the ZoL Debian repo, I get a grub.cfg with entries that still have

{{{
root=ZFS=Patux/ ro boot=zfs $bootfs
}}}

with $bootfs defined as zfs-bootfs ($root) bootfs

Is this equivalent?

That's both under Debian (Testing) and under Ubuntu 14.04, btw. When I first rebooted my Ubuntu rig after today's upgrades, I was dumped at the busybox prompt because of a pool import failure. The bootstrap actually tried to import rpool (which I don't have) ... but it had already imported the correct pool. Is that due to the grub.cfg entry, or an issue with the new zfs-initramfs 0.6.3-2~trusty version? (Or maybe I should ask if the zfs-initramfs in the Debian repo is actually more recent/correct than the version for Ubuntu? ;) )

@FransUrbo
Copy link
Contributor

bootfs=rpool/ROOT/debian-1 boot=zfs ro

root=ZFS=Patux/ ro boot=zfs $bootfs

If you're using the zfs-initramfs from the Debian GNU/Linux repository, they should be the same (I'm not sure about the last slash in the dataset).

You should really have create a separate dataset for the root and not put them in the root dataset.

But it should work any way (possibly removing that slash). But only testing will tell (I've never seen this type of setup before so you'll be the first to confirm :).

if the zfs-initramfs in the Debian repo is actually more recent/correct than the version for Ubuntu? ;) )

Oh, yes!! I've basically rewritten the initrd scripts, supporting a ton of more
features etc (booting from a snapshot to name the most significant).

PS. This is really a support question, not a bug/issue. If you could be so kind to close this and continue this on the mailing list, I'd be most grateful.

@RJVB
Copy link
Author

RJVB commented Jun 14, 2014

Okidoki - I'd have done that earlier if it had been clearer that said "mailing list" is actually a Google Group not requiring subscription to YAML :)

@RJVB RJVB closed this as completed Jun 14, 2014
@RJVB RJVB changed the title 0.6.3: grub CMDLINE and booting anomalies? grub-probe adds trailing slash (if root is on the root dataset). Jun 17, 2014
@RJVB
Copy link
Author

RJVB commented Jun 17, 2014

Reopened as requested [https://groups.google.com/a/zfsonlinux.org/d/msg/zfs-discuss/hHzJ3GwmKE8/fMHg6G8I3jsJ] and relabeled. I am not able to confirm nor infirm that no trailing slash is added when the OS root is NOT in the root dataset, so I put that condition in parentheses.

@RJVB RJVB reopened this Jun 17, 2014
@FransUrbo
Copy link
Contributor

I am not able to confirm nor infirm that no trailing slash is added when the OS root is NOT in the root dataset, so I put that condition in parentheses.

It doesn't (tested it a couple of times myself on my test machines).

But the label is ok. I'll look into this when I have more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants