ctx is a defined function parameter that's always overwritten, i.e. never in kwargs

[jimdewees]

pyre/pyre/pyre.py

Line 41 in b2a3c9b

ctx = kwargs.get('ctx')

>>> class C(object):
...     def __init__(self, ctx=None, *args, **kwargs):
...         print(ctx, kwargs, kwargs.get('ctx'))
...
>>> try:
...     c1 = C('this', ctx='that')
... except TypeError as err:
...     print(err)
...
__init__() got multiple values for argument 'ctx'
>>> try:
...     c2 = C(ctx='this', **{'ctx': 'that'})
... except TypeError as err:
...     print(err)
...
type object got multiple values for keyword argument 'ctx'
>>> c3 = C('this', _ctx='that')
this {'_ctx': 'that'} None
>>> c4 = C(ctx='this is not in kwargs')
this is not in kwargs {} None
>>> c5 = C(**{'ctx': 'neither is this'})
neither is this {} None

[sphaero]

so what are you suggesting?

[jimdewees]

The docstring for zmq.Context.instance provides a good implementation example.

[sphaero]

You're not very verbose. Are you suggesting that:

ctx = kwargs.get('ctx')
if ctx == None:
    ctx = zmq.Context()
self._ctx = ctx

should be reduced to

self._ctx = ctx or zmq.Context()

[fieldOfView]

That would fix the issue that you are trying to get ctx from the kwargs dict, whereas it is defined as a proper keyword argument in the __init__ method definition.