Description link colors don't respect current theme

[Jamesgsburns]

What happened?

I was expecting one of you to notice, it must have been the update.

Platform

Userscript

Version

2.5.4

What browser are you on?

Chrome

Browser version

Present version

Link to the video

https://www.youtube.com/watch?v=ykC7HZ1-FrQ

Screenshots or Videos

About you

• I am a developer and/or have knowledge in programming

[drunkwinter]

Was not able to reproduce, but did notice that it looked different with the script on.

[drunkwinter]

Alright looks like I might have found where the problem is. YouTube has something called 'attributed description' which includes text colors based on the current theme, but the proxy always assumes we are in dark theme. Hence why the description may look weird with the light theme on.

@zerodytrash We probably need to get this from the client, but there is no way for me to test if this actually fixes it.

Simple-YouTube-Age-Restriction-Bypass/account-proxy/lib/innertubeApi.js

Line 31 in a80c32a

"userInterfaceTheme": "USER_INTERFACE_THEME_DARK",

[drunkwinter]

Ok, I just figured that I could test this with non age restricted videos and it did work.

The fix will be included in the next release. Thanks for reporting.

@zerodytrash

[Jamesgsburns]

This description thing has happened before (I think once when i got this) and it was fixed, either it was automatically fixed or another update. (didn't find out)

[drunkwinter]

Fixed in 2.5.5

[Jamesgsburns]

"Fixed in 2.5.5"
Oh really now? I even checked and it was in the current update and I reinstalled it and...!
https://github-production-user-asset-6210df.s3.amazonaws.com/121324756/246622045-7e9af270-e375-4efc-8c5b-af4d2f6f33b2.png

[drunkwinter]

The proxy server probably still runs on old code and needs to be updated.

@zerodytrash Could we improve the process by auto deploying somehow?

[drunkwinter]

I thought this was only going to be a server side fix, but we found a bug in the client...

@Jamesgsburns Could you try out this build?

• Simple-YouTube-Age-Restriction-Bypass.user.zip

[Jamesgsburns]

That didn't work for me... Also last night, the sidebar and description were missing again and they just came back but not only did it NOT fix this issue, but that did NOT fix issue #169 either.

[drunkwinter]

That didn't work for me...

How about this one:

• Simple-YouTube-Age-Restriction-Bypass.user.zip

Also last night, the sidebar and description were missing again and they just came back but not only did it NOT fix this issue

Yes, when updating the server a regression was found, which then resulted in bad responses. This is now resolved.

but that did NOT fix issue #169 either

This was not mean to fix issue #169, that's unrelated.

[Jamesgsburns]

Unfortunately that did the exact same thing. It could be because it says it's an unknown publisher, I'm not the best with files.
Is there any possible way to just have it show just the youtube link itself or use some userscript or extension anywhere?

[drunkwinter]

@Jamesgsburns

If you have Tampermonkey:

1. Disable the current Simple-YouTube-Age-Restriction-Bypass

2. Click on Create a new script

3. Delete everything and then copy and paste the contents of this file:
   Simple-YouTube-Age-Restriction-Bypass.user.js.txt

4. Save by pressing CTRL+S or clicking on File -> Save

[Jamesgsburns]

OMG that worked? Is there any way to update the userscript with that? Keep this issue open for the other people.
Something strange I should say is that the YouTube link update came out when they changed the layout in October, but that didn't happen to me until this issue happened. At the end of September, the description was gone but later on at the beginning of October it came back but it had this issue. But then in November, it was back to becoming actual links. I don't get why the updated description happened originally that late for me...

[drunkwinter]

Alright I'll close this issue when the next version is released.

[drunkwinter]

Fixed in 2.5.6.