New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reload File document after S3 Upload #39

Open

fahimalizain wants to merge 1 commit into zerodha:master from leam-tech:file_url_bug

Contributor

fahimalizain commented Jun 3, 2021

Two issues are being fixed here:

Not all File uploads are image_field uploads. If a File was uploaded on a Doctype with image_field specified, that do not mean that File was uploaded for the image_field
Reload the File document before returning so that frappe-js sets the correct file_urls in Attach & Attach Image fields


          fix: Reload File document after S3 Upload

d771b10

chitly mentioned this pull request

Fix bugs I found in this app Tacten/frappe-attachments-s3#3

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet