You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, whenever we encounter an error (Result::Err I'm talking about), we usually just ignore it by calling ok(), then skipping whatever we were about to do.
It would be better to properly report any actual errors back to the language client, instead of silently hiding them.
The text was updated successfully, but these errors were encountered:
Some of this errors should just be emitted to the Slice trace while others emitted to the user in the form of a popup like how 0e69963 does for Diagnostics without spans.
Currently, whenever we encounter an error (
Result::Err
I'm talking about), we usually just ignore it by callingok()
, then skipping whatever we were about to do.It would be better to properly report any actual errors back to the language client, instead of silently hiding them.
The text was updated successfully, but these errors were encountered: