Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly Log Errors #19

Open
InsertCreativityHere opened this issue Nov 29, 2023 · 1 comment
Open

Properly Log Errors #19

InsertCreativityHere opened this issue Nov 29, 2023 · 1 comment

Comments

@InsertCreativityHere
Copy link
Member

Currently, whenever we encounter an error (Result::Err I'm talking about), we usually just ignore it by calling ok(), then skipping whatever we were about to do.

It would be better to properly report any actual errors back to the language client, instead of silently hiding them.

@ReeceHumphreys
Copy link
Contributor

Some of this errors should just be emitted to the Slice trace while others emitted to the user in the form of a popup like how 0e69963 does for Diagnostics without spans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants