Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad java formatting #2758

Open
bernardnormier opened this issue Sep 20, 2024 · 1 comment
Open

Bad java formatting #2758

bernardnormier opened this issue Sep 20, 2024 · 1 comment
Labels
Milestone

Comments

@bernardnormier
Copy link
Member

The Java formatting in some files is very very strange.

For example:

@bernardnormier bernardnormier added this to the 3.8.0 milestone Sep 20, 2024
@InsertCreativityHere
Copy link
Member

The cause of the strangeness is that the formatting plug-in we're using has a hard column limit of 100.
So, in heavily nested code like what you posted, where the entire block is very near to that 100 column limit, the formatter starts doing crazy things to try and avoid hitting that limit.

We could switch to a different formatter that lets us set a higher upper limit of 120.
Or go back to manually formatting the code in this file instead of relying on janky auto-formatters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants