Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support >1.0 for OpenAI integration/package #2210

Open
1 task
strickvl opened this issue Jan 3, 2024 · 6 comments
Open
1 task

Support >1.0 for OpenAI integration/package #2210

strickvl opened this issue Jan 3, 2024 · 6 comments
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers

Comments

@strickvl
Copy link
Contributor

strickvl commented Jan 3, 2024

Open Source Contributors Welcomed!

Please comment below if you would like to work on this issue!

Contact Details [Optional]

[email protected]

What happened?

The current openai integration in ZenML is pinned to versions below 1.0.0. However, OpenAI has recently released a significant update (version 1.0.0 and above), which includes major changes. To stay up-to-date and take advantage of the new features and improvements, ZenML needs to support the latest OpenAI versions. This update might necessitate a breaking change in ZenML, shifting to support only versions >1.0.0 of the OpenAI integration.

Task Description

Update the openai integration within ZenML to support versions >=1.0.0. This task involves:

  • Unpinning the current version restriction in src/zenml/integrations/openai/init.py.
  • Ensuring compatibility with the new OpenAI version 1.0.0 and above.
  • Making necessary adjustments or rewrites in the ZenML codebase to accommodate any breaking changes introduced in the new OpenAI version.
  • Updating documentation and examples to reflect the new integration version support.
  • Considering making this update a breaking change for ZenML, where only OpenAI versions >1.0.0 will be supported going forward.

Expected Outcome

Successful integration of OpenAI version 1.0.0 and above in ZenML, with all tests passing and documentation updated to guide users on the new integration version.

Additional context

This update is crucial to keep ZenML integrations current and to provide users with the latest features and improvements from OpenAI.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@strickvl strickvl added bug Something isn't working good first issue Good for newcomers dependencies Pull requests that update a dependency file and removed bug Something isn't working labels Jan 3, 2024
@strickvl strickvl changed the title Support >1.0 for OpenAI integration/package Support >1.0 for OpenAI integration/package Jan 3, 2024
@Senthi1Kumar
Copy link

Hi @strickvl, should I work on this issue

@strickvl
Copy link
Contributor Author

@Senthi1Kumar if you'd like to! Please make sure to follow our contributors guide, esp by branching off and making your PR to the develop branch. Let us know if you have further questions or if you'd like to discuss your approach etc.

@remiBoudreau
Copy link

remiBoudreau commented Feb 9, 2024

Having ridiculous trouble getting this to work with all the dependencies resolved... when i run

zenml integration install -y -i feast

or

pip install docs/.requirements-docs-frozen.txt

using the Docker container for zenml-dev.Dockerfile, the dependencies become impossible to resolve. If I change the versions for packages with conflicting dependencies, it creates a chain of more packages with conflicting dependencies...

@strickvl
Copy link
Contributor Author

strickvl commented Feb 11, 2024 via email

@strickvl
Copy link
Contributor Author

strickvl commented Feb 11, 2024

Actually, now that I took a closer look, this issue/task is blocked until we upgrade our Pydantic dependency to >2.0.0, since OpenAI pin this to v2.4.2. We're starting to work on this internally, but I'd hold off on this for the moment as it's currently impossible.

@remiBoudreau
Copy link

Okay no worries. Thanks for giving me the heads up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants