Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New stack showcase #91

Merged
merged 20 commits into from
Feb 19, 2024
Merged

New stack showcase #91

merged 20 commits into from
Feb 19, 2024

Conversation

avishniakov
Copy link
Contributor

All now is encapsulated in run.ipynb. It all starts with a quick walkthrough of the starter-template, followed by introducing production runs on different stacks (including sagemaker step operator), followed by results analysis (including WandB showing up at the end).
@htahir1 , let me know what you think about it.

@avishniakov avishniakov requested a review from htahir1 February 8, 2024 11:39
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! A lot is good here but I think we need to keep the deployment pipeline and logic around as it might be another demo.. it also might make sense to change this project folders name to something more appropriate... not sure what ATM

I want to use this as a base for different demos we do

@avishniakov
Copy link
Contributor Author

Nice one! A lot is good here but I think we need to keep the deployment pipeline and logic around as it might be another demo.. it also might make sense to change this project folders name to something more appropriate... not sure what ATM

I want to use this as a base for different demos we do

Make sense, I was just building it around the starter, which has no deployment pipeline in it. I'll take the needed actions.

@avishniakov avishniakov merged commit 6ca7ba5 into main Feb 19, 2024
1 of 3 checks passed
@avishniakov avishniakov deleted the feature/new-stack-showcase branch February 19, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants