From 46d5841ad373d633044d8c2aa91783aadbf1507b Mon Sep 17 00:00:00 2001 From: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> Date: Fri, 19 Jul 2024 10:25:02 +0200 Subject: [PATCH 1/2] UV for Docker by default --- template/config.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/template/config.yaml b/template/config.yaml index bde6901..8630f12 100644 --- a/template/config.yaml +++ b/template/config.yaml @@ -6,7 +6,11 @@ settings: parent_image: 'huggingface/transformers-pytorch-gpu' build_options: platform: 'linux/amd64' + python_package_installer_args: + system: null {%- endif %} + python_package_installer: uv + install_stack_requirements: False required_integrations: {%- if cloud_of_choice == 'aws' %} - aws From bfbc824c4c38c83780cdd4efe70b25afd5808061 Mon Sep 17 00:00:00 2001 From: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> Date: Fri, 19 Jul 2024 11:00:13 +0200 Subject: [PATCH 2/2] fix windows testing --- .github/workflows/ci.yml | 1 + tests/conftest.py | 9 ++++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 230ed9c..20b6285 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -36,6 +36,7 @@ jobs: run-tests: runs-on: ${{ matrix.os }} strategy: + fail-fast: false matrix: stack-name: [local] os: [windows-latest, ubuntu-latest, macos-13] diff --git a/tests/conftest.py b/tests/conftest.py index aaec33c..5ec3260 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -14,6 +14,7 @@ import os +import sys import shutil from typing import Generator @@ -99,4 +100,10 @@ def clean_zenml_client( # remove all traces, and change working directory back to base path os.chdir(orig_cwd) - shutil.rmtree(str(tmp_path)) + if sys.platform == "win32": + try: + shutil.rmtree(str(tmp_path)) + except: + pass + else: + shutil.rmtree(str(tmp_path))