Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Batch Template: Adding Python 3.12 to the workflows #40

Merged
merged 2 commits into from
Sep 3, 2024
Merged

E2E Batch Template: Adding Python 3.12 to the workflows #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bf13bf
added 3.12
bcdurak Aug 29, 2024
4030718
win tests fix
avishniakov Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
matrix:
stack-name: [local]
os: [windows-latest, ubuntu-latest, macos-latest]
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
env:
ZENML_DEBUG: true
ZENML_ANALYTICS_OPT_IN: false
Expand All @@ -57,5 +57,5 @@ jobs:
with:
stack-name: ${{ matrix.stack-name }}
python-version: ${{ matrix.python-version }}
ref-zenml: ${{ inputs.ref-zenml || 'develop' }}
ref-zenml: ${{ inputs.ref-zenml || 'feature/PRD-566-dependency-cleanup' }}
ref-template: ${{ inputs.ref-template || github.ref }}
9 changes: 8 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@
# permissions and limitations under the License.


import contextlib
import os
import sys
import shutil
from typing import Generator

Expand Down Expand Up @@ -99,6 +101,11 @@ def clean_zenml_client(
GlobalConfiguration._reset_instance(original_config)
Client._reset_instance(original_client)

# remove all traces, and change working directory back to base path
# remove all traces, and change working directory back to base path
os.chdir(orig_cwd)
shutil.rmtree(str(tmp_path))
if sys.platform == "win32":
with contextlib.suppress(Exception):
shutil.rmtree(str(tmp_path))
else:
shutil.rmtree(str(tmp_path))
Loading