Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Fix BC break introduced by 3fc1e66 #180

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Fix BC break introduced by 3fc1e66 #180

merged 1 commit into from
Jul 19, 2017

Conversation

tca3
Copy link
Contributor

@tca3 tca3 commented Jul 18, 2017 •
edited
Loading

Fixes #170 and #176 by using finfo's destructor via unset:

Thus avoiding the call to an invalid finfo resource while still avoiding the segfault bug on older PHP versions.

@tca3
Copy link
Contributor Author

tca3 commented Jul 18, 2017

@weierophinney could we at the very least rollback the commit ? The MimeType validator is not usable anymore for multiple file validation.

@froschdesign
Copy link
Member

@ThomasCantonnet
This will not fix #170, because the problem is different.

@tca3
Copy link
Contributor Author

tca3 commented Jul 18, 2017

@froschdesign IsImage is calling the MimeType validator and errors on the same line, did I miss something?

@froschdesign
Copy link
Member

@ThomasCantonnet

…did I miss something?

The problem in #170 is related to multiple files and the entire $_FILES array, but this is not supported.

@tca3
Copy link
Contributor Author

tca3 commented Jul 18, 2017

@froschdesign right this is kind of a side effect to #176 then, the issue remains even without the error i suppose?

@froschdesign
Copy link
Member

froschdesign commented Jul 18, 2017 •
edited
Loading

@ThomasCantonnet
Not a side effect, because the $_FILES array can include multiple file values, but this is not supported. So, this is an entirely different problem.

Your fix for #176 is correct.

@weierophinney weierophinney added this to the 2.9.2 milestone Jul 19, 2017
@weierophinney weierophinney merged commit d3a3be6 into zendframework:master Jul 19, 2017
weierophinney added a commit that referenced this pull request Jul 19, 2017
@weierophinney
Merge pull request #180 from ThomasCantonnet/finfo-bc-break
1b7725e 
Fix BC break introduced by 3fc1e66
weierophinney added a commit that referenced this pull request Jul 19, 2017
@weierophinney
Adds CHANGELOG for #180
a56abf9
weierophinney added a commit that referenced this pull request Jul 19, 2017
@weierophinney
Merge branch 'hotfix/180'
8a34a5a 
Close #180
Fixes #170
Fixes #176
weierophinney added a commit that referenced this pull request Jul 19, 2017
@weierophinney
Merge branch 'hotfix/180' into develop
f012441 
Forward port #180
@weierophinney
Copy link
Member

Thanks, @ThomasCantonnet

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@froschdesign froschdesign froschdesign approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.9.2
Development

Successfully merging this pull request may close these issues.

MimeType validator doesn't work for multiple files.
3 participants
@tca3 @froschdesign @weierophinney