Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Court] Disputes should be one at a time, and historical dispute data should be kept around until resolution #372

Closed
lsaether opened this issue Nov 19, 2021 · 5 comments
Assignees
Labels
l:L Solving the issue takes weeks p:medium Medium priority, this issue can wait but should be done fairly soon t:bug The issue describes a bug

Comments

@lsaether
Copy link
Member

The current implementation of the Court pallet needs to be improved in two respects:

  • A market can only have one "court case" occurring at once. Currently the pallet allows for disputes to take place without any waiting time, overwriting the previous data immediately. A new court case can only be called after the conclusion of the prior court case.
  • We need to keep historical data of court cases for a market, at least until that market resolves. This is so that we can properly reward / slash good and bad actors during the entire proceedings of cases. Once a market resolves, and the rewards and slashes have been divvied out, the items can be deleted from storage.
@Robiquet
Copy link
Member

Robiquet commented Dec 10, 2021

A few other notes from my side:

  • Votes can be changed, even after the end block has passed
  • Jurors that have failed to vote still have the 'ok' status, I was expecting them to become 'tardy' Edit: looks like juror status is tardy now, not sure what happened
  • Disputes can be created when there are no jurors
  • When someone joins the court they are not added to existing cases despite being needed (not sure if this is by design)

@sea212 sea212 added p:medium Medium priority, this issue can wait but should be done fairly soon t:bug The issue describes a bug labels Feb 25, 2022
@maltekliemann maltekliemann added this to the v0.3.4 milestone May 4, 2022
@maltekliemann maltekliemann removed this from the v0.3.4 milestone Jun 7, 2022
@maltekliemann
Copy link
Member

I propose the following solution: The dispute method of DisputeApi may error with DisputeInProgress if a dispute has already been registered, but hasn't been handled by the dispute mechanism. For example:

  • Authorized::dispute errors with DisputeInProgress if the market has been disputed but the authorized account hasn't responed yet
  • Court::dispute errors with DisputeInProgress if the market has been disputed but the court case is not yet closed

This solution won't work with SimpleDisputes, but since that's getting removed anyways, we're fine.

@maltekliemann
Copy link
Member

Another problem uncovered in recent meetings: When using authorized, people can call dispute even after the authority has submitted a report.

I think the correct solution is to make appeals (i.e. second, third, etc. disputes) part of the DisputeApi and only have a single dispute in prediction-markets, which, if called, passes control for the decision of the market over to the dispute mechanism. This gives us more freedom in how we implement the DisputeApi. Then authorized be designed to now allow any appeals, but court can be.

@sea212 sea212 added the l:M Solving the issue takes days label Oct 12, 2022
@sea212 sea212 added this to the v0.3.7 milestone Oct 12, 2022
@Chralt98
Copy link
Member

Chralt98 commented Oct 31, 2022

I added multiple issues to address ZIP-0 and ZIP-2 here.

@Chralt98 Chralt98 removed this from the v0.3.7 milestone Nov 3, 2022
@sea212 sea212 added l:L Solving the issue takes weeks and removed l:M Solving the issue takes days labels Jan 4, 2023
@sea212 sea212 added this to the v0.3.9 milestone Jan 4, 2023
@sea212 sea212 modified the milestones: v0.3.9, v0.4.0 Jun 13, 2023
@sea212 sea212 modified the milestones: v0.3.10, v0.3.11 Jul 20, 2023
@sea212 sea212 removed this from the v0.3.11 milestone Aug 3, 2023
@Chralt98
Copy link
Member

Fixed by #976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l:L Solving the issue takes weeks p:medium Medium priority, this issue can wait but should be done fairly soon t:bug The issue describes a bug
Projects
None yet
Development

No branches or pull requests

5 participants