Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two bugs in the dkms scripts #15

Open
msjarrell opened this issue Jun 24, 2018 · 2 comments
Open

Two bugs in the dkms scripts #15

msjarrell opened this issue Jun 24, 2018 · 2 comments

Comments

@msjarrell
Copy link

I found two small typos in the dkms scripts.

First, the dkms-install.sh script fails to copy the source to /usr/src. This may be fixed by making the change

cp -r ../${DRV_DIR} /usr/src/${DRV_NAME}-${DRV_VERSION}

cp -r ../${DRV_DIR}-${DRV_VERSION} /usr/src/${DRV_NAME}-${DRV_VERSION}

Second, the dkms-remove script fails to remove the files from /usr/src. This may be fixed by the change

dkms remove ${DRV_NAME}/${DRV_VERSION} --all

dkms remove -m ${DRV_NAME} -v ${DRV_VERSION} --all

After this all worked very well (thank you zebulon2!).

@zebulon2
Copy link
Owner

Thanks, will take care of it soon.

@zebulon2
Copy link
Owner

Thank you for your debugging, but it seems these two files should be deleted, since these install and remove are deprecated and should be handled in the dkms.conf file with DEST_MODULE_LOCATION[#]= statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants