Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install_opencv in the RoSys docker image to support omnidirectional cameras #182

Open
codingpaula opened this issue Aug 27, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@codingpaula
Copy link
Contributor

Currently the docker image doesn't install the opencv requirements like in the pytest action and as specified in the install_opencv.py script. But the dependencies in the script are necessary to e.g. run the tests correctly. When adding the same line as in the pytest action to the Dockerfile, I get the following error:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/local/lib/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1324, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'install_opencv'
@codingpaula codingpaula added the bug Something isn't working label Aug 27, 2024
@rodja
Copy link
Member

rodja commented Aug 27, 2024

@codingpaula is that fixed with #181?

@codingpaula
Copy link
Contributor Author

No, #181 just fixes the base image and installing the full project (before running the image resulted in missing the version).

@falkoschindler
Copy link
Contributor

In b43b47c I added checks if omnidir is properly installed. Otherwise we simply ignore corresponding tests. This allows running tests locally and in other environments without the special install_opencv workaround. So this issue can focus on making camera calibration for omnidirectional cameras available to user code based on the RoSys docker image.

@falkoschindler falkoschindler changed the title install_opencv in docker image Fix install_opencv in the RoSys docker image to support omnidirectional cameras Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants