Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress, Statuses, and Completion Values #11

Closed
jamiebuilds opened this issue Aug 7, 2018 · 0 comments · Fixed by #13
Closed

Progress, Statuses, and Completion Values #11

jamiebuilds opened this issue Aug 7, 2018 · 0 comments · Fixed by #13

Comments

@jamiebuilds
Copy link
Member

A couple things:

  • Right now there is no way to report that something has "failed" but is still running (ex: a single test failed, but we're running the rest to see what happens)
  • There is no way to report progress, TAP has test plans, but we could do more.
  • Completion "events" are confusing:
    • More than one: "passed", "failed"
    • Is "skipped" a completion event? (i.e. can a "started" entity later become "skipped"
    • Should there be more events for completion states like "errored"?

idea:

Here is a vague idea of what we could do: (Note: I don't like this very much atm)

// init state:
{ id: "0",   kind: "item",  event: "started",   status: "running" }

// child success:
{ id: "0.0", kind: "check", event: "started",   status: "running" }
{ id: "0.0", kind: "check", event: "completed", status: "passed"  }

// child fail:
{ id: "0.1", kind: "check", event: "started",   status: "running" }
{ id: "0.1", kind: "check", event: "completed", status: "failed"  }

// notify state change of parent:
{ id: "0",   kind: "item",  event: "progress",  status: "failed"  }

// child success:
{ id: "0.2", kind: "check", event: "started",   status: "running" }
{ id: "0.2", kind: "check", event: "completed", status: "passed"  }

// child errored:
{ id: "0.3", kind: "check", event: "started",   status: "running" }
{ id: "0.3", kind: "check", event: "completed", status: "errored" }

// final state:
{ id: "0",   kind: "item",  event: "completed", status: "failed"  }

There would be 3 "event"'s:

  • "started"
  • "progress"
  • "completed"

There would be 4 "status"'s:

  • "running"
  • "passed"
  • "failed"
  • "skipped"
  • "errored"

We could also add a progress field:

{ ... kind: "group", event: "started", progress: { completed: 4, planned: 20 } ... }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant