Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Custom Attribute passing in <fragment> not working since 3.8.0 #332

Open
pmoisel opened this issue Jul 29, 2020 · 1 comment
Open

Custom Attribute passing in <fragment> not working since 3.8.0 #332

pmoisel opened this issue Jul 29, 2020 · 1 comment

Comments

@pmoisel
Copy link

pmoisel commented Jul 29, 2020

readme.md states "Other attributes are allowed and will be passed as well to relevant functions (eg. filterRequestHeaders, filterResponseHeaders, etc.)", and we do rely on this.

After quite some time we wanted to update tailor and I ran into this bug:
fragment.js:26 const getAttributes = (tag, context) =>
changed in commitId d05e816 to improve performance. Thus, now not assigning custom attributes.

Is it okay to go back to "old" behaviour?

Regards

@pmoisel
Copy link
Author

pmoisel commented May 12, 2021

duplicate of #287 , fixed in #323

Can we expect a new release? 3.9.2 is of Nov 15, 2018... @vigneshshanmugam ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant