Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

Propagate $ENABLE_INTROSPECTION environment variable passthough to the planb-tokeninfo fix #489

Open
smirnov opened this issue Mar 16, 2018 · 4 comments

Comments

@smirnov
Copy link
Member

smirnov commented Mar 16, 2018

Enable passthrough of environment variable ENABLE_INTROSPECTION to the planb upstart job and startup script.

smirnov added a commit that referenced this issue Mar 16, 2018
smirnov added a commit that referenced this issue Mar 22, 2018
aermakov-zalando pushed a commit that referenced this issue Mar 23, 2018
* #489 allow enabling introspection for planb-tokeninfo service

* #489 add handling of empty value case

* #489 add missing upstart conf
@jbspeakr
Copy link
Member

seems to work with TaupageStaging-AMI-20180323-150822. close?

@jbspeakr
Copy link
Member

jbspeakr commented Mar 26, 2018

wait. this looks weird:

  • in the taupage setup the variable tokeninfo_enable_introspection get's written into meta.
  • but in tokeninfo init it expects tokeninfo_introspection to be present in meta.

I would expect introspection not to work anymore after a reboot. also those inconsistencies make it really hard to figure out what to use. please make it consistent to our current docs.

@jbspeakr
Copy link
Member

jbspeakr commented Mar 26, 2018

also it would be nice to have a consistent naming schema for related config:
local_planb_tokeninfo: true together with tokeninfo_introspection: true is not nice.

I would prefer something like local_planb_tokeninfo: trueand local_planb_tokeninfo_introspection: true

let's fix this and adapt our docs.

@smirnov
Copy link
Member Author

smirnov commented Mar 26, 2018

The second instance of propagation (in the setup script, it's needed to propagate secret-vars.sh overlay) can be dropped altogether and just be kept in the upstart init script (then this setting will require to be set explicitly in senza.yaml).

smirnov added a commit that referenced this issue Apr 10, 2018
smirnov added a commit that referenced this issue Apr 10, 2018
aermakov-zalando pushed a commit that referenced this issue Apr 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants