Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Resource Owner Password Credentials flow #3

Open
alex94cp opened this issue Aug 10, 2015 · 8 comments
Open

Missing Resource Owner Password Credentials flow #3

alex94cp opened this issue Aug 10, 2015 · 8 comments

Comments

@alex94cp
Copy link

According to the rfc, the ROPC flow can also be used when there is a high degree of trust between the resource owner and the client, as it's the case with a first-party app, where the use of an implicit flow would hurt UX. OAuth2-client lacks this ROPC flow.

@prayerslayer
Copy link
Contributor

Yup, correct. I’ll see when I have some time to implement it.

I’m curious: Do you intend to use the library in the browser or on the server?

@alex94cp
Copy link
Author

In the browser, it's a simple React app. I plan to go isomorphic in the
future though.

Álex Puchades
El 11/8/2015 7:59, "Nikolaus Piccolotto" [email protected]
escribió:

Yup, correct. I’ll see when I have some time to implement it.

I’m curious: Do you intend to use the library in the browser or on the
server?


Reply to this email directly or view it on GitHub
#3 (comment)
.

@prayerslayer
Copy link
Contributor

Aren’t you exposing your client credentials (including the secret) then?

@alex94cp
Copy link
Author

Nope. OAuth2 distinguishes two client types: confidential and public (see here). Public clients are not required to provide its client_secret (as it's the case for an ajax app). I'm using this passport strategy on the server to protect the token endpoint.

@prayerslayer
Copy link
Contributor

Ah, so you can do the ROPC flow with non-confidential clients as well. I kind of overread that.

prayerslayer added a commit that referenced this issue Aug 11, 2015
state is not available with ROPC
prayerslayer added a commit that referenced this issue Aug 11, 2015
just to make this library more isomorphic
prayerslayer added a commit that referenced this issue Aug 11, 2015
requestToken will now return an intermediate representation of the http
request (can be either a redirect or a post)
prayerslayer added a commit that referenced this issue Aug 11, 2015
@lasomethingsomething
Copy link

@prayerslayer Do you still want this enhancement? If so, can we open it up to "Help Wanted"?

@prayerslayer
Copy link
Contributor

prayerslayer commented Nov 28, 2016

Yes, do want. It's unlikely I get to this myself though, so I added the help label.

@lasomethingsomething
Copy link

@prayerslayer Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants