Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trayBin: fallback to self install? #7

Open
cryptix opened this issue Jul 8, 2018 · 1 comment
Open

trayBin: fallback to self install? #7

cryptix opened this issue Jul 8, 2018 · 1 comment

Comments

@cryptix
Copy link

cryptix commented Jul 8, 2018

I'm having problems with the way the helper binaries are stuffed under $HOME/.cache. It has problems on uncommon platforms and hides an external dependency.

Supporting other architectures, like arm(64), will also lead to an explosion of files in the trayBin folder and increase the size of the npm package much more.

Wouldn't it make more sense to clearly state the external dependeny and make individual packages for systray-portable? As a gopher myself I could help with that.

A more nodejs/self-contained approach would be native cxx module but that is not my arena of expertise.
@cryptix cryptix mentioned this issue Jul 8, 2018
Closed
cryptix added a commit to ssb-junkyard/forked-systrayhelper that referenced this issue Jul 8, 2018
@cryptix
don't track binary output
99cc53a 
I don't think this is good practice.
see zaaack/node-systray#7
@zaaack
Copy link
Owner

zaaack commented Jul 9, 2018 •
edited
Loading

  1. You can specific custom copy directory via copyDir

  2. You are right, individual packages are better but its a little tedious for the benefits because I haven't add new features for a long time, especially currently I have no project is using this package. But I can review PRs and publish new packages if I have time, so prs are still welcome!

  3. I have think about this before, but go is not good to commuticate with node, I have tried rs-systray but it doesn't support macOS.

cryptix added a commit to ssb-junkyard/forked-systrayhelper that referenced this issue Jul 10, 2018
@cryptix
don't track binary output
c18e04a 
I don't think this is good practice.
see zaaack/node-systray#7
cryptix added a commit to ssbc/forked-systray that referenced this issue Jul 10, 2018
@cryptix
removed prebuilt
e421633 
breaks current behaviour but I find it unclean and not maintainable. See
zaaack#7
cryptix referenced this issue in ssbc/forked-systray Jul 10, 2018
@cryptix
replaced lookup logic with a unix-ish system whereis
0630eeb 
updates issue #7
@cryptix cryptix mentioned this issue Aug 30, 2018
Closed
2 tasks
cryptix added a commit to ssbc/forked-systray that referenced this issue Sep 1, 2018
@cryptix
removed prebuilt binaries
889561a 
the previous behaviour I found unclean and not maintainable.
See zaaack#7

This uses a postinstall helper script instead to download a release.
https://docs.npmjs.com/misc/scripts

replaced lookup logic with a unix-ish system whereis (updates issue #7)

the dependencies of the package are needed by the postinstall script.
i wish there was a way to make this clear to npm..
i wonder how typescript works around this?!

closes #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cryptix @zaaack