Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxes missing at all? #4

Open
papillon6 opened this issue Feb 24, 2016 · 7 comments
Open

Taxes missing at all? #4

papillon6 opened this issue Feb 24, 2016 · 7 comments

Comments

@papillon6
Copy link

Hi yvoronoy,

i think i found a bug. The extra fee is just added "on top" of all costs, without respecting taxes. Here a short example.
First without extra fee - standard functions of magento:

subtotal (without tax): 10€
shipping (without tax): 5€
/---------------------------------
tax (19%): 2,85€
/---------------------------------
total (including tax): 17,85€

Now i add an extra fee of 5€. What your extension does:

subtotal (without tax): 10€
shipping (without tax): 5€
/---------------------------------
tax (19%): 2,85€
extra fee: 5€
/---------------------------------
total (including tax): 22,85€

That's obviously wrong, because the extra fee is calculated without any taxes.
What it should do:

subtotal (without tax): 10€
shipping (without tax): 5€
extra fee (without tax): 5€
/---------------------------------
tax (19%): 3,80€
/---------------------------------
total (including tax): 23,80€

Did i miss a configuration-option?

Regards!

@yvoronoy
Copy link
Owner

Hi @papillon6
Thank you for reporting this issue.

I think we should add configuration to choose needed behaviour.
Since at now taxes doesn't respect extra fee at all.

@crysix
Copy link

crysix commented Mar 10, 2016

The Problem here is the sorting, Magento is a bit buggy here.
I also made an Fee Extension which had the same problem.
It could be easy fixed by changing
<.after.>subtotal</.after.>
<.before.>grand_total</.before.>
In the config.xml.

You have to play a bit with the values. Multiple values could be needed and could be used by "," as separator. E.g.
<.after.>nominal,subtotal</.after.>
<.before.>grand_total</.before.>

Take a look into sales config for examples:
app\code\core\Mage\Sales\etc\config.xml

@crysix
Copy link

crysix commented Mar 11, 2016

Well as I figured out, this will only fix the tax usage in general, but not the tax calculation for the fee amount. For this it seems you have to add the tax in the collect method, which worked for me so far. Maybe there is a better way.
I did it similar to here: app\code\core\Mage\Tax\Model\Sales\Total\Quote\Tax.php

@crysix
Copy link

crysix commented Apr 14, 2016

Any news on this problem?

@yvoronoy
Copy link
Owner

Actually there is no solution yet @crysix
You are welcome for pull requests if you have solution.

@colinozanne
Copy link

Hi Yvoronoy,
that's a very interesting module but unfortunatelly it is crashing my front end (back end ok).
Is it compatible with Magento 1.7?
Thank you
Colin

@etsanov
Copy link

etsanov commented Dec 18, 2017

Is there a way to add the proper amount to the taxes and the total so that calculations are correct? Right now the extra fee is like a totally separate amount added to the total and does not respect any taxes, which creates problems with various payment processors (e.g. I'm personally having problems with myPos).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants