Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with pnpm / vite / windows #19

Open
Makio64 opened this issue Sep 3, 2023 · 0 comments
Open

Error with pnpm / vite / windows #19

Makio64 opened this issue Sep 3, 2023 · 0 comments

Comments

@Makio64
Copy link

Makio64 commented Sep 3, 2023

Hello,

I got an error on my windows,

Fhis didnt work :
const threeBundleSuffix = path.sep + path.join("node_modules", "three", "build", "three.module.js");
it end up in node_modules\three\build\three.module.js but it should be node_modules/three/build/three.module.js

Once this is fixed : it reduce the chunk only from 585.40 kB to 564.44kB ( I think its only the gl constant but not proper tree shaking )

three v155
vite 4.4.9

export default defineConfig({
	plugins: [
		{ ...threeMinifier(), enforce: 'pre' },
		basicSsl(),
                //etc..
	],

tried with pnpm & yarn both same result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant