Skip to content

Commit

Permalink
Merge pull request #96 from yukiarrr/fix-version-v1.7.0
Browse files Browse the repository at this point in the history
Fix version v1.7.0
  • Loading branch information
yukiarrr authored Apr 6, 2023
2 parents 645dc08 + e9cf01a commit d6ccc6f
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 10 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ You can add a single p12 key+cert file with `p12-base64 (p12-path)`, or if you h
**Required**: Base64 encoded mobileprovision file. If you want to specify multiple files, you need to input in multiple lines and then use [`export-options`](#export-options) to specify the provisioning profile to use for each executable in your app.

```yaml
- uses: yukiarrr/ios-build-action@v1.6.0
- uses: yukiarrr/ios-build-action@v1.7.0
with:
mobileprovision-base64: |
${{ secrets.MY_MOBILEPROVISION_BASE64 }}
Expand All @@ -59,7 +59,7 @@ Also note, when creating base64 encoded inputs, make sure they don't contain new
**Required**: mobileprovision path. If you want to specify multiple files, you need to input in multiple lines and then use [`export-options`](#export-options) to specify the provisioning profile to use for each executable in your app.

```yaml
- uses: yukiarrr/ios-build-action@v1.6.0
- uses: yukiarrr/ios-build-action@v1.7.0
with:
mobileprovision-path: |
ios-build-1.mobileprovision
Expand Down Expand Up @@ -107,7 +107,7 @@ Output path of ipa. Default `"output.ipa"`.
Targets to be updated with mobileprovision, code signing identity, etc. Split on new lines. Default `""`. (default to all targets)

```yaml
- uses: yukiarrr/ios-build-action@v1.6.0
- uses: yukiarrr/ios-build-action@v1.7.0
with:
update-targets: |
MyApp
Expand Down Expand Up @@ -155,7 +155,7 @@ Welcome your contributions!
### single p12

```yaml
- uses: yukiarrr/ios-build-action@v1.6.0
- uses: yukiarrr/ios-build-action@v1.7.0
with:
project-path: Unity-iPhone.xcodeproj
p12-base64: ${{ secrets.P12_BASE64 }}
Expand All @@ -168,7 +168,7 @@ Welcome your contributions!
### key and cert

```yaml
- uses: yukiarrr/ios-build-action@v1.6.0
- uses: yukiarrr/ios-build-action@v1.7.0
with:
project-path: Unity-iPhone.xcodeproj
p12-key-base64: ${{ secrets.P12_KEY_BASE64 }}
Expand Down
13 changes: 8 additions & 5 deletions fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,12 @@ platform :ios do
path: ENV['PROJECT_PATH'],
code_sign_identity: ENV['CODE_SIGNING_IDENTITY'],
targets: update_targets,
entitlements_file_path: ENV['ENTITLMENTS_FILE_PATH']
entitlements_file_path:
if !ENV['ENTITLMENTS_FILE_PATH'].empty?
ENV['ENTITLMENTS_FILE_PATH']
else
nil
end
)

if @profiles.length == 1
Expand Down Expand Up @@ -141,10 +146,8 @@ platform :ios do
use_build_destination = !ENV['BUILD_DESTINATION'].empty?
use_cloned_source_packages_path = !ENV['CLONED_SOURCE_PACKAGES_PATH'].empty?

if ENV['INCREMENT_BUILD_NUMBER'] == "true"
increment_build_number(
xcodeproj: ENV['PROJECT_PATH']
)
if ENV['INCREMENT_BUILD_NUMBER'] == 'true'
increment_build_number(xcodeproj: ENV['PROJECT_PATH'])
end

build_app(
Expand Down

0 comments on commit d6ccc6f

Please sign in to comment.