-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification around OREC="3" fix #70
Comments
Hi @shackbarth, Just a fellow user who is also currently testing the package. I see that you are testing the I was under the impression that |
I think in theory a patient could have an "original reason" of ESRD, but after a successful kidney transplant they don't actually have ESRD anymore and should just get run through the v28 model. But, sure, even if that's how the rules are set up, it would be rare. In any case, even within the ESRD model, the SAS model gives ORIGDS = 1 only when OREC = 1, so this same bug still holds, if it is a bug. We're finding it a bit more difficult to do an apples-to-apples between SAS and hccpy on the ESRD model in general tho. |
Pretty sure they would actually get a post-graft risk score from the ESRD model. You can verify which model a member score was calculated by looking at the risk adjustment factor type code on their MMR record. (C3-C8, I3-I9 are some of the post-graft community score types.)
Agreed and would say that this is a symptom of a bigger issue. ESRD is essentially not implemented for I've built out the package for ESRDv24 but intend to clean it up before doing a pull request. |
@shackbarth, thanks for bringing this to our attention. To be honest, I don't recall the rationale you seek. I will try to understand this in more detail and get back to you. If folks are running the model using incorrect assumptions re: OREC, perhaps it makes sense to match the CMS implementation exactly and throw an error message to warn. @sethclaw Sounds great and thanks for your contributions! |
@shackbarth I agree that it is a bug on CMS's side. I think '3' should be included in the ESRD logic. But until then, aligning with CMS seems the route to go. |
any updates on the package for ESRDv24 @sethclaw? 🙏 |
resolves yubin-park#70. orec in ('2', '3') is the definition for the origesrd variable and only comes into play with the ESRD risk score models and not the non-ESRD community models. origesrd drive interactions with Sex for the Dialysis model. See lines 500-504 of E2424T2M.TXT in the CMS's ESRD software E2424.86.T2
Hello maintainers! We're very excited about this project, and have been checking the hccpy output against the official SAS version Everything matches up great except for the circumstance where the OREC is "3".
For example,
When we revert the diff from #32 then the misalignment gets fixed. That change was certainly deliberate and there was a fair amount of conversation that went into it. But the existing code certainly seemed to be able to handle the orec="3" and the SAS code does not have a similar tweak:
hccpy/hccpy/data/AGESEXV2.TXT
Line 72 in 8b52cae
Can you clarify the rationale behind this update? @kevinbuchanjr 's paragraphs in the PR are (I believe) more like caveats than an explanation about what inspired the fix in the first place.
The text was updated successfully, but these errors were encountered: