Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove claimtype arameter from raeligible.iseligible() method #36

Open
dr00b opened this issue Jun 7, 2022 · 1 comment
Open

Remove claimtype arameter from raeligible.iseligible() method #36

dr00b opened this issue Jun 7, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@dr00b
Copy link
Collaborator

dr00b commented Jun 7, 2022

@yubin-park I will definitely add claims eligibility source doc to the readme.

Considering TOB code is defining the OP / IP categories, does it make sense to remove the 'claimtype' parameter from the raeligible.iseligible() method? Including the claimtype parameter means the user will have to apply the TOB mapping before using the function. So the filter is essentially applied twice.
@dr00b dr00b changed the title Remove IP / OP / Professional Parameter from RAEligible function Remove claimtype arameter from raeligible.iseligible() method Jun 7, 2022
@yubin-park
Copy link
Owner

@dr00b yes, please go ahead!

@dr00b dr00b added the enhancement New feature or request label Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yubin-park @dr00b