Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.3nm EDRs will crash Calman #6

Open
24fpsDaVinci opened this issue Sep 6, 2022 · 5 comments
Open

3.3nm EDRs will crash Calman #6

24fpsDaVinci opened this issue Sep 6, 2022 · 5 comments

Comments

@24fpsDaVinci
Copy link

24fpsDaVinci commented Sep 6, 2022

I am guessing because spectral_data.space_nm is not defined in edr.py, Calman is treating 3.3nm EDRs as 1nm...

when running the EDRs back into oeminst you will get this error.

File './LG-Oled-6-Series_fixed.edr' set 0 number of samles 109 doesn't match wavelengths 361

only 1nm files work correctly.

@24fpsDaVinci 24fpsDaVinci changed the title major issues and crashing with latest calman home for LG release 3.3nm EDRs will crash Calman Sep 8, 2022
@aron7awol
Copy link

aron7awol commented Feb 21, 2023

Interpolating to 1nm and then converting to EDR should work perfectly fine. I did it yesterday and sent the resulting EDR to others for testing.

Sprague (1880) method is recommended by the CIE for interpolating functions having a uniformly spaced independent variable.

There's a SpragueInterpolator available in https://github.com/colour-science/colour

@24fpsDaVinci
Copy link
Author

amazing thank you

@bnjmnrchrt
Copy link

Interpolating to 1nm and then converting to EDR should work perfectly fine. I did it yesterday and sent the resulting EDR to others for testing.

Sprague (1880) method is recommended by the CIE for interpolating functions having a uniformly spaced independent variable.

There's a SpragueInterpolator available in https://github.com/colour-science/colour

Can you send me the .edr file, that would be nice.

@24fpsDaVinci
Copy link
Author

@bnjmnrchrt checkout aron7awol's fork, its patched for automatic conversion.

@24fpsDaVinci
Copy link
Author

24fpsDaVinci commented Jun 11, 2023

@aron7awolin your fork, I had to add . back in or i will get import error

from .cgats import CGATS
from .edr import (

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants